A fortnightly review club for Lightning Dev Kit (LDK) PRs
What is this? Â A fortnightly club for reviewing LDK PRs at 18:00 UTC every second Friday in the #review-club channel on our Discord server.
What’s it for?  To help newer contributors learn about the LDK review process. The review club is not primarily intended to help open PRs get merged.
Who should take part? Â Anyone who wants to learn about contributing to LDK. All are welcome to come and ask questions!
How do I take part? Just show up on our Discord! See Attending your first PR Review Club for more tips on how to participate.
Who runs this? Â Upcoming meetings are scheduled by LDK contributor dunxen. The meetings are hosted by a variety of LDK contributors. See some of our previous hosts.
Upcoming Meetings
| 13 Nov 2023 | » | #2419 Interactive Transaction Construction (InteractiveTxConstructor, splicing, dual-funding) hosted by dunxen |
| 12 Jan 2024 | » | #2760 Fix infinite loop when closing a pre-funding channel (channel-establishment, channel-funding) hosted by jbesraa |
We’re always looking for interesting PRs to discuss in the review club and for volunteer hosts to lead the discussion:
- If there’s a PR that you’d like to discuss in a future meeting, feel free to suggest it in the Discord channel.
- If you’d like to host a meeting, look at the information for meeting hosts and contact dunxen on Discord.
Recent Meetings
| 13 Oct 2023 | » | #2618 Include an `outbound_payment` flag in `MaybeTimeoutClaimableHTLC` (ChannelMonitor) hosted by dunxen |
| 15 Sep 2023 | » | #1924 Handle if funding output is in a coinbase transaction (ChannelManager, Channel) hosted by dunxen |
| 18 Aug 2023 | » | #2495 Use a single peer state map for all channel phases in peer state (channel, ChannelPhase, ChannelManager, PeerState) hosted by vladimirfomene |
| 04 Aug 2023 | » | #2428 Wait to create a channel until after accepting. (channel, ChannelManager) hosted by dunxen |
See all meetings.
Other Resources for New Contributors
- Read the Contributing to LDK Guide. This will help you understand the process and some of the terminology we use in LDK.
- Look at the Good First Issues and Up For Grabs list.
- Brush up on your Rust. There are many references available over and above The Book.